-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RIP upper_bound #779
RIP upper_bound #779
Conversation
(see this example) This branch: julia> @btime ρ($d, Intersection($X, $H))
27.810 μs (463 allocations: 41.88 KiB)
2.0000000000000004
julia> @btime ρ($d, Intersection($X, Intersection($X, $H)))
28.197 μs (468 allocations: 42.13 KiB)
2.0 Master: julia> @btime ρ($d, $X∩$H, upper_bound=true)
31.114 μs (570 allocations: 50.28 KiB)
2.0000000000000004
julia> @btime ρ($d, $X∩($X∩$H), upper_bound=true)
10.865 ms (182473 allocations: 14.96 MiB)
2.0000000000000004 EDIT: julia> set = load("set.jld"); # contains A⌜R⋂G⌟⋂I
julia> d = [0.0, 1.0];
julia> S = set["set"];
julia> @time ρ(d, S)
4.173353 seconds (57.84 M allocations: 1.386 GiB, 16.97% gc time) |
this idea wouldl be useful because saves the inrmediate emptiness checks in the iteration phase. |
Because I guess you run into the same problem as before: It still uses the line search recursively. I will spend some more time in refactoring #778. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
No description provided.